Am I doing melodic-vocal analysis right?

After two years of learning how to play guitar with tabs, and Rocksmith, and some scale study (specifically d minor and d harmonic minor) I want to improve. I’m getting nowhere with noodling around, in different keys and scales, Im awful when it comes to hitting chord tones and my lead playing is in the dumps when it comes to being on time. I’m trying to get better with riffing too as I’m a big metal and jazz guy. My personal guitar hero is Synyster Gates.

Anyways, in trying to get more serious about learning my fretboard intimately and being able to compose music. So I’m trying to combine a few different studies together while going through these books. I’m also trying to find how the melodies are connected along with vocals and lyric structure and the chord changes. Maybe I’m mixing too much in all at once.

Any advice?

TL:DR; any recommendations on more resources geared towards melody composition for beginners or should I wait before tackling these things?

After two years of learning how to play guitar with tabs, and Rocksmith, and some scale study (specifically d minor and d harmonic minor) I want to improve. I’m getting nowhere with noodling around, in different keys and scales, Im awful when it comes to hitting chord tones and my lead playing is in the dumps when it comes to being on time. I’m trying to get better with riffing too as I’m a big metal and jazz guy. My personal guitar hero is Synyster Gates.

Anyways, in trying to get more serious about learning my fretboard intimately and being able to compose music. So I’m trying to combine a few different studies together while going through these books. I’m also trying to find how the melodies are connected along with vocals and lyric structure and the chord changes. Maybe I’m mixing too much in all at once.

Any advice?

TL:DR; any recommendations on more resources geared towards melody composition for beginners or should I wait before tackling these things?